Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[업로드] 파일 선택 #105

Merged
merged 7 commits into from
Nov 16, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@
<navigation xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
android:id="@+id/nav_graph"
app:startDestination="@id/login_nav_graph">
app:startDestination="@id/upload_nav_graph">

<include app:graph="@navigation/home_navigation" />
<include app:graph="@navigation/login_navigation" />
<include app:graph="@navigation/upload_navigation" />

</navigation>
1 change: 1 addition & 0 deletions android/core/ui/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,5 @@
<string name="title">제목</string>
<string name="genre">장르</string>
<string name="description">설명</string>
<string name="select_thumbnail">썸네일 이미지 선택</string>
</resources>
2 changes: 1 addition & 1 deletion android/feature/upload/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@ android {
}

dependencies {

implementation(libs.appcompat)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요건 언제 쓰신 건가여?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

registerForActivityResult의 파라미터 넣어줄 때 사용하는 PickVisualMedia랑 ActivityResultContracts가 액티비티를 필요로 해요

}
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,42 @@ package com.ohdodok.catchytape.feature.upload

import android.os.Bundle
import android.view.View
import androidx.activity.result.contract.ActivityResultContracts
import androidx.activity.result.contract.ActivityResultContracts.PickVisualMedia
import androidx.core.net.toFile
import androidx.fragment.app.viewModels
import com.ohdodok.catchytape.catchytape.upload.R
import com.ohdodok.catchytape.catchytape.upload.databinding.FragmentUploadBinding
import com.ohdodok.catchytape.core.ui.BaseFragment
import dagger.hilt.android.AndroidEntryPoint

@AndroidEntryPoint
class UploadFragment : BaseFragment<FragmentUploadBinding>(R.layout.fragment_upload) {
private val viewModel: UploadViewModel by viewModels()

private val pickMedia = registerForActivityResult(PickVisualMedia()) { uri ->
if (uri == null) return@registerForActivityResult

viewModel.uploadImage(uri.toFile())
}

private val filePickerLauncher =
registerForActivityResult(ActivityResultContracts.GetContent()) { uri ->
if (uri == null) return@registerForActivityResult

viewModel.uploadAudio(uri.toFile())
}

Copy link
Member

@youlalala youlalala Nov 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2개 변수명 비슷한 형식으로 다시 짓는거 어떨까용??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영해서 올릴게~

override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
super.onViewCreated(view, savedInstanceState)
binding.viewModel = viewModel

setupSelectThumbnailImage()
}

private fun setupSelectThumbnailImage() {
binding.cvUploadThumbnail.setOnClickListener {
filePickerLauncher.launch("audio/*")
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setUpSelectThumbnailImage 인데 filePickerLauncher가 아니라 pickMedia 를 써야할 것 같네용!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트하다가 잘못 올라갔넹 ㅠㅠ
수정할게

}
Original file line number Diff line number Diff line change
@@ -1,7 +1,23 @@
package com.ohdodok.catchytape.feature.upload

import androidx.lifecycle.ViewModel
import dagger.hilt.android.lifecycle.HiltViewModel
import java.io.File
import javax.inject.Inject

class UploadViewModel : ViewModel() {
@HiltViewModel
class UploadViewModel @Inject constructor(

) : ViewModel() {

private var uploadedImage: String? = null
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아직 개발이 덜 되어서, 놔두신것 같은데, nullable 한 string으로 하신 이유가 궁금합니다!
lateinit var 을 쓸 수 도 있을거 같아요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네이밍은 uploadedImageUrl이 더 적절할 수도 있겠네...
이 프로퍼티는 서버로 썸네일 이미지가 올라갔을 때 채워질 프로퍼티야. 아직 썸네일이 없을 수도 있으니 nullable로 뒀어

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

썸네일이 없는 경우는 Blank("") 로 하는 건 어떠신가요???

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변수명은 말씀하신것 처럼 'uploadedImageUrl' 이 더 적절해 보입니다~


fun uploadImage(imageFile: File) {
// todo : image 파일을 업로드 한다.
// todo : 반환 값을 uploadedImage에 저장한다.
}

fun uploadAudio(audioFile: File) {
// todo : audio 파일을 업로드 한다.
}
}
20 changes: 15 additions & 5 deletions android/feature/upload/src/main/res/layout/fragment_upload.xml
Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,27 @@
android:layout_marginTop="@dimen/extra_large"
app:cardBackgroundColor="@color/on_surface_variant"
app:cardCornerRadius="20dp"
app:cardElevation="0dp"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@id/tb_upload_appbar">
app:layout_constraintTop_toBottomOf="@id/tb_upload_appbar"
android:contentDescription="@string/select_thumbnail">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD@!~!


<ImageButton
android:id="@+id/btn_select_thumbnail"
<ImageView
android:id="@+id/iv_thumbnail_image"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_gravity="center"
android:background="@color/white"
android:importantForAccessibility="no" />

<ImageView
android:id="@+id/iv_camera_icon"
android:layout_width="48dp"
android:layout_height="48dp"
android:layout_gravity="center"
android:background="@drawable/ic_camera"
android:backgroundTint="@color/surface" />
android:src="@drawable/ic_camera"
android:importantForAccessibility="no"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

importantForAccessibility 이거 처음봐서 어떤건지 궁금하네요1!!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no를 지정하면 스크린 리더가 해당 View를 읽지 않는다는데, 이 아이콘은 장식용 아이콘이라 읽지 않아도 된다고 판단했어.
대신 상위 CardView에 contentDescription을 추가해서 어떤 동작을 수행할 수 있는지 명시해주고 있어


</androidx.cardview.widget.CardView>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<navigation xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/upload_navigation"
android:id="@+id/upload_nav_graph"
app:startDestination="@id/upload_navigation">

<fragment
Expand Down
Loading