Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: introduce 2 workflows to manage the PR deployments #702

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Apr 24, 2024

Previously, there was a single workflow to deploy 2 PR previews.
But the deployment URL depends on the job id, so the 2 deployments were done with the same URL whereas they should have their own.

Covers #686
Covers #700

Copy link
Contributor

github-actions bot commented Apr 24, 2024

🎊 PR Preview 00d04f2 has been successfully built and deployed to https://bonitasoft-bonita-documentation-site-deploy-pr-preview-pr-702.surge.sh

🕐 Build time: 0.012s

🤖 By surge-preview

Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@tbouffard tbouffard changed the title ci: test the new surge preview deployment [POC] ci: introduce 2 workflows to manage the PR deployments Apr 25, 2024
Copy link
Contributor

@benjaminParisel benjaminParisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbouffard tbouffard marked this pull request as ready for review April 25, 2024 08:47
@tbouffard tbouffard merged commit 8cf2284 into master Apr 25, 2024
6 checks passed
@tbouffard tbouffard deleted the ci/test_pr_preview_deploy branch April 25, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants