forked from GafferHQ/gaffer
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update some GUI for Arnold #1
Open
rachyid
wants to merge
262
commits into
boberfly:master
Choose a base branch
from
hypothetical-inc:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e problem Representative error from MSVC: error LNK2019: unresolved external symbol "public: static unsigned __int64 __cdecl Imath_2_2::limits<unsigned __int64>::max(void)" (?m ax@?$limits@_K@Imath_2_2@@SA_KXZ) referenced in function "public: void __cdecl Gaffer::Switch<class Gaffer::ComputeNode>::setup(class Gaffer::Plug co nst *)"
error C2248: 'GafferImageUI::ImageGadget::TileIndex': cannot access private struct declared in class 'GafferImageUI::ImageGadget'
ArrayPlug.obj : error LNK2019: unresolved external symbol "public: static unsigned __int64 __cdecl Imath_2_2::limits<unsigned __int64>::max(void)" (?max@?$limits@_K@Imath_2_2@@SA_KXZ) referenced in function "public: void __cdecl Gaffer::ArrayPlug::`default constructor closure'(void)"
error C2872: 'list': ambiguous symbol 'std::list': class has no constructors 'boost::python::ssize_t boost::python::len(const boost::python::api::object &)': cannot convert argument 1 from 'std::list' to 'const boost::python::api::object &' binary '[': 'std::list' does not define this operator or a conversion to a type acceptable to the predefined operator 'arg': ambiguous symbol 'std::arg': no matching overloaded function found '_Promote_to_float<_Ty>::type std::arg(_Ty)': could not deduce template argument for '<unnamed-symbol>' '_Ty std::arg(const std::complex<_Other> &)': could not deduce template argument for 'const std::complex<_Other> &' from 'const char [5]' '_Ty std::arg(const std::complex<_Other> &)': could not deduce template argument for 'const std::complex<_Other> &' from 'const char [10]' '_Ty std::arg(const std::complex<_Other> &)': could not deduce template argument for 'const std::complex<_Other> &' from 'const char [6]'
Despite AcademySoftwareFoundation/OpenShadingLanguage#1360, we have still seen one example of an empty `.oso` file being produced in production. Adding further checks will hopefully help us get to the bottom of it if it happens again.
We were doing a complete (and completely unnecessary) recursive bounds evaluation of `/GAFFERBOT` when creating a branch at `/children`. In this case, `branchesData->locationOrAncestor( "/GAFFERBOT" )` correctly returned the root location, but we incorrectly interpreted that as meaning that `/GAFFERBOT` was an ancestor of the branch. If `path` is deeper than `location`, then path _cannot_ be the ancestor of a branch.
OSLCode : Check for empty `.oso` files
BranchCreator : Fix unnecessary input bounds evaluation
At IE we often re-run an installation script and run into failures because the top level directory exists. This has been an annoyance in the past, but now that Arnold installs to subdirectories this becomes more problematic.
Install : Allow updating an existing install tree
GadgetWidget : Don't steal wheel events from overlay widgets
PathListingWidget : Add `columnAt()` method
Gaffer 0.61 UI Fixes
PathListingWidget : Fix unwanted expansion when clicking to select
This should have been bumped _before_ 0.60.12.1 was tagged. Not sure if we want to force re-tag or release 0.60.12.2 (making this commit a bit silly)
We had been getting away with this up till now, but Arnold 7 is less forgiving and crashes when a node is destroyed after its universe. Strangely, our existing `RendererTest.testAOVShaders` didn't catch this crash, but it reproduced every time when rendering via the GUI.
CI : Check SConstruct version matches tag version
Arnold Renderer : Destroy AOV shaders before universe
Doc : ControlsAndShortcuts : Add doc for Luminance hotkey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just override the mtd file in C:\Gaffer\arnold\plugins
Layer_rgba
Layer_float
aiImage
ShadowMatte
Triplanar
Clean up some following nodes ( should be hidden)
[node visible_light]
[node maya_layered_shader]
[node c4d_texture_tag_rgba]
[node c4d_texture_tag]
[node query_shape]
https://github.com/rachyid/Gaffer-Arnold-GUI-shaders