fix: make handleCreateBucketSynPackage forward compatible
#509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pythonberg1997
force-pushed
the
develop
branch
2 times, most recently
from
33a071a to
9e7fe74
Compare
pythonberg1997
force-pushed
the
develop
branch
from
9e7fe74 to
5306857
Compare
unclezoro
approved these changes
Oct 23, 2023
|
Looks good to me, please ensure it is well tested locally. |
| @@ -140,6 +196,24 @@ func DeserializeCrossChainPackage(rawPack []byte, channelId sdk.ChannelID, packa | |||
| return operationMap[packageType](pack.Package) | |||
| } | |||
|
|
|||
| func DeserializeCrossChainPackageV2(rawPack []byte, channelId sdk.ChannelID, packageType sdk.CrossChainPackageType) (interface{}, error) { | |||
There was a problem hiding this comment.
Can we reuse DeserializeCrossChainPackage or extract another method to reduce duplicated codes?
yutianwu
approved these changes
Oct 23, 2023
forcodedancing
approved these changes
Oct 23, 2023
This was referenced Nov 2, 2023
This was referenced Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is to fix the forward incompatibility of
handleCreateBucketSynPackageRationale
To make the chain forward compatible
Example
The chain can handle
CreateBucketSynPackagewith or withoutGlobalVirtualGroupFamilyIdChanges
Notable changes:
handleCreateBucketSynPackageV2