Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vote: disable votepool when bsc protocol not enabled #1804

Conversation

NathanBSC
Copy link
Contributor

@NathanBSC NathanBSC commented Aug 7, 2023

Description

disable votepool when bsc protocol not enabled

Rationale

we need a emergency handler when chain stopped after plato upgrade,

set flag disablebscprotocol will disable vote propagation, so most parts of fast finality have been disabled,

but votpool will still be constructed.

In this PR, we disable votepool when bsc protocol not enabled, so we can use flag disablebscprotocol to remove

fast finality much more clean

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@NathanBSC NathanBSC closed this Aug 7, 2023
@NathanBSC NathanBSC deleted the DisableBscProtocol_control_votepool branch August 7, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant