fix: do not print private key in log #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
reviewed
Jun 20, 2024
node/validator.go
Outdated
| PayAccountAddress string | ||
| SentryAccountMode account.Mode | ||
| // SentryPrivateKey private key of sentry wallet | ||
| SentryPrivateKey string |
There was a problem hiding this comment.
Please dont do such modification, it is a breaking change to external validators.
If they upgrade to the latest release, then they have to change the configures, if they dont, there is no error log to info them at all.
unclezoro
reviewed
Jun 20, 2024
cmd/main.go
Outdated
| @@ -37,7 +37,8 @@ func main() { | |||
|
|
|||
| openPrometheusAndPprof(cfg.Debug.ListenAddr) | |||
|
|
|||
| log.Infow("bsc mev-sentry start", "configPath", *configPath, "config", cfg) | |||
| hidedCfg, _ := cfg.HidePrivateKey() | |||
| log.Infow("bsc mev-sentry start", "configPath", *configPath, "config", hidedCfg) | |||
There was a problem hiding this comment.
I dont think it is necessary to print the whole setting in the log. ( Do not see similar logic in other repo like BSC, opBNB)
unclezoro
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add a description of your changes here...
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: