Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for passing LocalizationsDelegates #97

Merged

Conversation

Joran-Dob
Copy link
Contributor

Added support for passing LocalizationsDelegates so nested MaterialApp supports localization.

This can be best viewed as an minor improvement that elevates some challenges when working with Dashbook and localizations. But not an overall fix, it might be nice to also pass different local related params or work with localizations in an complete different structure.

Might also help with resolving or improving support for #72

Copy link
Member

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erickzanardo erickzanardo merged commit 84d84e4 into bluefireteam:main Dec 9, 2022
@Joran-Dob Joran-Dob deleted the feature/localization-support branch December 9, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants