Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(optimism): Re-use L1BlockInfoTx from Maili #1993

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

refcell
Copy link
Contributor

@refcell refcell commented Jan 13, 2025

Description

Kona as well as other libraries + applications use optimism types from maili. maili-protocol exposes the L1BlockInfoTx type that provides all the functionality used in revm's custom L1BlockInfo type.

This PR removes the redundant L1BlockInfo type from revm, using maili_protocol::L1BlockInfoTx instead.

@refcell refcell marked this pull request as ready for review January 13, 2025 19:19
Copy link

codspeed-hq bot commented Jan 13, 2025

CodSpeed Performance Report

Merging #1993 will improve performances by 3.04%

Comparing op-rs:maili (74155f3) with main (bc44ae1)

Summary

⚡ 1 improvements
✅ 7 untouched benchmarks

Benchmarks breakdown

Benchmark main op-rs:maili Change
burntpix 5.5 s 5.3 s +3.04%

@rakita
Copy link
Member

rakita commented Jan 14, 2025

This dependency becomes hard to support as it ties revm release with maili. We had a similar discussion about alloy types and Revm, where nobody wanted to include each other.

For Optimism it seems more obvious what to do, wdyt about moving revm-optimism to a standalone repo, it can be in in bluealloy/revm-optimism or of your choosing?

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also recommend not integrating this from mali because this makes the upgrade path more complex, unless l1blockinfo is coming from a standalone crate

@refcell refcell marked this pull request as draft January 14, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants