Fix compiler errors and some error paths #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling pystack with gcc 14, the C++ standard library headers are not giving us transitevely the 'algorithm' include and we are missing it explicitly so it currently fails to compile. Additionally, we are not properly handling some of the exceptions that are being raised when something fails when copying memory when we are resolving the Python version. Signed-off-by: Pablo Galindo <[email protected]>
godlygeek
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling pystack with gcc 14, the C++ standard library headers are
not giving us transitevely the 'algorithm' include and we are missing it
explicitly so it currently fails to compile.
Additionally, we are not properly handling some of the exceptions that
are being raised when something fails when copying memory when we are
resolving the Python version.
Issue number of the reported bug or feature request: #
Describe your changes
A clear and concise description of the changes you have made.
Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.
Additional context
Add any other context about your contribution here.