-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Fix test suite on Alpine #185
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The native frames that we get without the libpython debug info are:
We see def _is_eval_frame(symbol: str, python_version: Tuple[int, int]) -> bool:
if python_version < (3, 6):
return "PyEval_EvalFrameEx" in symbol
return "_PyEval_EvalFrameDefault" in symbol is returning false for every frame, and we're not able to produce a hybrid stack. |
pablogsal
reviewed
May 24, 2024
pablogsal
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one nit :)
We're no longer able to correctly identify `_PyEval_EvalFrameDefault` on Alpine without debug info. This test was already adding symlinks to the split debug info for `ld-musl`, so let's extend that hack to also symlink to the split debug info for `libpython`. Signed-off-by: Matt Wozniski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're no longer able to correctly identify
_PyEval_EvalFrameDefault
on Alpine without debug info.This test was already adding symlinks to the split debug info for
ld-musl
, so let's extend that hack to also symlink to the split debug info forlibpython
.