Fallback to the first executable map if the given executable is invalid #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
force-pushed
the
executable
branch
3 times, most recently
from
056b93c
to
b4f4bd6
Compare
godlygeek
requested changes
Jul 22, 2024
godlygeek
force-pushed
the
executable
branch
2 times, most recently
from
25a44d2
to
0e46e16
Compare
godlygeek
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
You accidentally implemented the opposite of what I asked for - you had us fall back onto this autodetection only if the user did provide an executable on the command line, instead of only if they didn't.
I've fixed that, and moved this detection up a bit higher in the file where it seems to fit better. After those changes, this LGTM. If you're happy with my changes, please squash them and 🚀
When a core file is created from a Python script that's executed directly via shebang, the reported executable will be the shell script. This is a problem because when we proceed to analyse the core file pystack fails as this is not the correct binary that was used to generate the core. To avoid this problem, detect when this happens and fall back to the executable reported in the first map that has a path in the core, which is generally the real executable that we need. Signed-off-by: Pablo Galindo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a core file is created from a Python script that's executed
directly via shebang, the reported executable will be the shell script.
This is a problem because when we proceed to analyse the core file
pystack fails as this is not the correct binary that was used to
generate the core.
To avoid this problem, detect when this happens and fall back to the
executable reported in the first map that has a path in the core, which
is generally the real executable that we need.
Issue number of the reported bug or feature request: #
Describe your changes
A clear and concise description of the changes you have made.
Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.
Additional context
Add any other context about your contribution here.