RDISCROWD-7573 update error on nonexistent project id in task API #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n00rsy
changed the title
Pull Request Test Coverage Report for Build 11712107488Details
💛 - Coveralls |
kbecker42
reviewed
Oct 31, 2024
pybossa/api/task.py
Outdated
| @@ -102,6 +102,8 @@ def _preprocess_post_data(self, data): | |||
| if 'n_answers' not in data: | |||
| project = project_repo.get(project_id) | |||
| data['n_answers'] = project.get_default_n_answers() | |||
| if not project: | |||
| raise BadRequest(f'Non existing project id {project_id}') | |||
There was a problem hiding this comment.
Are any other details of the request available inside data[] that would help identify the caller? If so, those could be included in the exception details.
There was a problem hiding this comment.
Please see the ticket comments for planned work on the gigwork listener to add identification for the caller. Thanks!
dchhabda
reviewed
Nov 4, 2024
dchhabda
approved these changes
Nov 4, 2024
dchhabda
requested changes
Nov 4, 2024
dchhabda
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: RDISCROWD-7573
Describe your changes
add project null check after fetching project info in
_preprocess_post_data