Simplify updating libbacktrace #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #652 +/- ##
==========================================
+ Coverage 92.55% 92.99% +0.44%
==========================================
Files 91 94 +3
Lines 11304 11420 +116
Branches 1581 2094 +513
==========================================
+ Hits 10462 10620 +158
+ Misses 837 800 -37
+ Partials 5 0 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Previously our `regenerate_libbacktrace.sh` script could only clone the repo and re-apply our existing patches. Give it the ability to also update to a different commit and rebase our patches. If the rebasing fails, have it leave the `.git` directory around so that a developer can manually rebase and finish the job. Signed-off-by: Matt Wozniski <[email protected]>
godlygeek
force-pushed
the
simplify_updating_libbacktrace
branch
from
501f611
to
4b0ed4f
Compare
pablogsal
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #651 and should be rebased on main once that one lands.