-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase Python Coverage #410
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #410 +/- ##
==========================================
+ Coverage 85.18% 91.66% +6.48%
==========================================
Files 29 90 +61
Lines 3631 10503 +6872
Branches 0 1448 +1448
==========================================
+ Hits 3093 9628 +6535
- Misses 538 872 +334
- Partials 0 3 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Hummm, seems that some of the parts that were added are having some problem (for some reason only on Alpine):
|
0574be4
to
6a7736d
Compare
Signed-off-by: Apurva Khatri <[email protected]>
Signed-off-by: Apurva Khatri <[email protected]>
Signed-off-by: Apurva Khatri <[email protected]>
Signed-off-by: Apurva Khatri <[email protected]>
Signed-off-by: Apurva Khatri <[email protected]>
6a7736d
to
948d4d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for contributing to memray @apurvakhatri !
*Issue number of the reported bug or feature request: #351 *
Describe your changes
The changes are - Python coverage report is generated & published to Codecov. Further, The report is analyzed & pragma no cover is added to increase test coverage.
Testing performed
I tested on a personal fork of the project using appropriate secrets for personal CodeCov.
Additional context
In order to publish python coverage to codecov build.yml had to be modified. During build the python coverage had to be performed using the development dependencies on ubuntu-latest & alpine linux container (Line 67 & 101 of build.yml respectively). This part of the build was failing as the systems were lacing lcov. Therefore lcov was added using apt-get & apk add for ubuntu & alpine respectively. Further, the publishing of code coverage report was resolved, but still 1 test is failing as the genhtml is unable to ignore the linecov error on alpine linux whereas it ignores it on ubuntu-latest. Any help on how to resolve this 1 check would be greatly appreciated. Thank you!