do not unlock views lock twice in explain schema system table queries #4954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are not collected (like, if this is an explain), we call sqlite3VdbeReset twice, once when we get the sqlite return code, and second when we finalize the statement. Reset the counter to avoid unlocking the views lock twice. Signed-off-by: Dorin Hogea <[email protected]>
markhannum
approved these changes
Jan 10, 2025
roborivers
suggested changes
Jan 10, 2025
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 324/597 tests failed ⚠.
The first 10 failing tests are:
incremental_backup [setup failure]
sc_redo_step [setup failure]
sc_lock_inversion [setup failure]
schemalk_extralock_generated [setup failure]
sc_dups_logicalsc_generated [setup failure]
oflowaddrem [setup failure]
largecsc2 [setup failure]
interval [setup failure]
phys_rep_perf
incremental_backup_usenames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we do not cache a statement that uses schema system tables that are not collected (like, if this is an explain), we call sqlite3VdbeReset twice, once when we get the sqlite return code, and second when we finalize the statement. Reset the counter to avoid unlocking the views lock twice.