Set generation from ckp-logs #4919
Conversation
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.
markhannum
force-pushed
the
setup_failure_fix
branch
from
94f781f to
01b86be
Compare
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 8/594 tests failed ⚠.
The first 10 failing tests are:
phys_rep_perf
triggersc_latency
logarchive
snapisol_partial_index_off_generated
snapisol_noearly_generated
snap_ha_retry_newsi_generated
ddl_csc2
simple_remsql_whitelist_generated
markhannum
force-pushed
the
setup_failure_fix
branch
8 times, most recently
from
daa207a to
d8f5729
Compare
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 142/595 tests failed ⚠.
The first 10 failing tests are:
phys_rep_perf
nogen_full_recovery_disable_generated
commit_delay_on_copy
simple_ssl
logarchive
snapisol_partial_index_off_generated
snapisol_noearly_generated
snap_ha_retry_newsi_generated
ddl_csc2
simple_remsql_whitelist_generated
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.
markhannum
force-pushed
the
setup_failure_fix
branch
2 times, most recently
from
1dae0ba to
e226f37
Compare
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 132/596 tests failed ⚠.
The first 10 failing tests are:
logfill
phys_rep_perf
nogen_full_recovery_disable_generated
analyze_partial_index_off_generated
analyze
logarchive
snapisol_partial_index_off_generated
snap_ha_retry_newsi_generated
ddl_csc2
simple_remsql_whitelist_generated
markhannum
force-pushed
the
setup_failure_fix
branch
3 times, most recently
from
fec372f to
5beb7ea
Compare
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 8/598 tests failed ⚠.
The first 10 failing tests are:
phys_rep_perf
analyze_partial_index_off_generated
logarchive
snapisol_noearly_generated
snap_ha_retry_newsi_generated
ddl_csc2
simple_remsql_whitelist_generated
sc_lotsoftables_logicalsc_generated
markhannum
force-pushed
the
setup_failure_fix
branch
2 times, most recently
from
b779a46 to
502b76c
Compare
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 6/598 tests failed ⚠.
The first 10 failing tests are:
phys_rep_perf
snapisol_noearly_generated
snap_ha_retry_newsi_generated
ddl_csc2
simple_remsql_whitelist_generated
disttxn
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 5/598 tests failed ⚠.
The first 10 failing tests are:
phys_rep_perf
snapisol
snap_ha_retry_newsi_generated
ddl_csc2
simple_remsql_whitelist_generated
markhannum
force-pushed
the
setup_failure_fix
branch
2 times, most recently
from
ea2b4b5 to
5fa615a
Compare
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 7/597 tests failed ⚠.
The first 10 failing tests are:
phys_rep_perf
analyze_exit_immediately
timepart_trunc_serialsc_generated
snapisol
snap_ha_retry_newsi_generated
ddl_csc2
simple_remsql_whitelist_generated
markhannum
force-pushed
the
setup_failure_fix
branch
from
5fa615a to
687d507
Compare
markhannum
force-pushed
the
setup_failure_fix
branch
from
407c61f to
5c0d3e2
Compare
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 7/597 tests failed ⚠.
The first 10 failing tests are:
phys_rep_perf
online_compaction
snapisol_partial_index_off_generated
snapisol
snap_ha_retry_newsi_generated
ddl_csc2
simple_remsql_whitelist_generated
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 6/597 tests failed ⚠.
The first 10 failing tests are:
phys_rep_perf
phys_rep_tiered_nosource_generated
snapisol_partial_index_off_generated
snap_ha_retry_newsi_generated
ddl_csc2
simple_remsql_whitelist_generated
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 9/597 tests failed ⚠.
The first 10 failing tests are:
sc_truncate
sc_transactional_rowlocks_generated
phys_rep_perf
snapisol_partial_index_off_generated
snap_ha_retry_newsi_generated
ddl_csc2
simple_remsql_whitelist_generated
phys_rep_tiered_firstfile_generated
sc_downgrade
markhannum
force-pushed
the
setup_failure_fix
branch
from
5c0d3e2 to
7e9481b
Compare
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 5/597 tests failed ⚠.
The first 10 failing tests are:
phys_rep_perf
op_makerecord
snap_ha_retry_newsi_generated
ddl_csc2
simple_remsql_whitelist_generated
Signed-off-by: Mark Hannum <[email protected]>
Signed-off-by: Mark Hannum <[email protected]>
markhannum
force-pushed
the
setup_failure_fix
branch
from
7e9481b to
02fd0c7
Compare
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 6/597 tests failed ⚠.
The first 10 failing tests are:
phys_rep_perf
snapisol_partial_index_off_generated
snapisol_noearly_generated
snap_ha_retry_newsi_generated
ddl_csc2
simple_remsql_whitelist_generated
Not writing rep-gen transaction records from full-recovery opened up situations where a node coming up would be able to see the most recently written generation only from checkpoint records. Because of this bug, it would then start to emit records at a lower generation than had been previously seen.
Additionally, Emit 'recovery-checkpoints' from recovery, which won't ever be used for matching. This is necessary because full-recovery needs to write a checkpoint using the most recent generation available in the transaction log. Because this record isn't emitted from the cluster-master, writing a normal checkpoint on the same generation re-opens the possibility that a replicant will incorrectly match. Solution is to only emit a 'recovery-checkpoint' from full-recovery.