PR switches remtran 2PC to run over cdb2api instead of legacy remtran plugin #4917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roborivers
suggested changes
Dec 17, 2024
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 7/593 tests failed ⚠.
The first 10 failing tests are:
phys_rep_perf
logarchive
snapisol_partial_index_off_generated
snapisol_noearly_generated
snapisol
snap_ha_retry_newsi_generated
simple_remsql_whitelist_generated
markhannum
previously approved these changes
Jan 21, 2025
… plugin. This extends the port of legacy remtran to cdb2api for 2PC transactional mode. NOTE: this handles the replicant to replicant communication. The master to master is already using cdb2api. Signed-off-by: Dorin Hogea <[email protected]>
dorinhogea
force-pushed
the
remtran2pc
branch
from
f1bfb15 to
4fa54b2
Compare
markhannum
approved these changes
Jan 21, 2025
|
@markhannum thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the port of legacy remtran to cdb2api for 2PC transactional mode (non-2pc was merged here).
NOTE: this handles the replicant to replicant communication. The master to master is already using cdb2api.