Print error trace when tmptable creation fails #2517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riverszhang89
requested changes
Sep 30, 2020
roborivers
suggested changes
Sep 30, 2020
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 6/373 tests failed ⚠.
The first 10 failing tests are:
fingerprints
auth_twofiles_generated
auth_queueodh_generated
auth
sc_constraints_logicalsc_generated
sc_constraints
adizaimi
force-pushed
the
az_verbose_tmtblcreate_failure
branch
from
12dff3b
to
3d6b070
Compare
adizaimi
changed the title
roborivers
suggested changes
Oct 1, 2020
There was a problem hiding this comment.
Coding style check: Error. Use clang-format or view diff ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 1/373 tests failed ⚠.
The first 10 failing tests are:
socksql_master_swings [core dumped]
riverszhang89
approved these changes
Oct 1, 2020
Also abort immediately when tmp tbl is null instead of crashing when we dereference its members. Signed-off-by: Adi Zaimi <[email protected]>
adizaimi
force-pushed
the
az_verbose_tmtblcreate_failure
branch
from
3d6b070
to
2581202
Compare
|
Thanks Rivers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also abort immediately when tmp tbl is null instead of
crashing when we dereference its members.
For issue #2518.
Signed-off-by: Adi Zaimi [email protected]