-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Log dumper #445
base: main
Are you sure you want to change the base?
Feat: Log dumper #445
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 294 of commit 004c2fc has completed with FAILURE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 298 of commit 28ec79b has completed with FAILURE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 300 of commit 8ce4504 has completed with FAILURE
Looks like there's a unit test for the log controller, let's extend that to test this as well. I think the most important thing to make sure of with this test is that we don't break compatibility with older configs that don't utilize this. |
9a30dd5
to
b827d6f
Compare
@chrisbeard I've added a unit test for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 310 of commit a63f4e7 has completed with FAILURE
5a0a785
to
7b9f24e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 351 of commit 7b9f24e has completed with FAILURE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 358 of commit f645c26 has completed with FAILURE
Signed-off-by: Anton Pryakhin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 360 of commit c3ef08d has completed with FAILURE
Introduce a set of parameters for log record dumping by a trigger message. This section can be added to the Broker config:
Where:
recordBufferSize
is a size of default logger's record buffer in bytes.recordingLevel
is the lowest severity level of the record that will be stored by the logger in its log record buffer.triggerLevel
is the lowest severity level of the record that will cause immediate publication of that record and any records in the logger's log record buffer.