Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor[BMQEVAL]: fix -WConversion warnings during compilation #395

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

mpak123
Copy link
Contributor

@mpak123 mpak123 commented Aug 9, 2024

*Issue number of the reported bug or feature request: #87 *

Describe your changes
This is a small good first issue contribution to fix -Wconversion warnings that pollutes the build log.

This particular PR deals with the following warnings in bmq:

/home/runner/work/blazingmq/blazingmq/src/groups/bmq/bmqeval/bmqeval_simpleevaluator.h:970:21: warning: conversion from ‘size_t’ {aka ‘long unsigned int’} to ‘int’ may change value [-Wconversion]
 970 |  return info.d_index; // RETURN
/home/runner/work/blazingmq/blazingmq/src/groups/bmq/bmqeval/bmqeval_simpleevaluator.h:973:29: warning: conversion from ‘size_t’ {aka ‘long unsigned int’} to ‘int’ may change value [-Wconversion]
 973 |  return iter->second.d_index; // RETURN

Testing performed
Observed build logs to confirm that warnings were pruned.

Additional context
Add any other context about your contribution here.

@mpak123 mpak123 requested a review from a team as a code owner August 9, 2024 16:59
@678098 678098 changed the title Fix WConversion warnings during compilation Refactor[BMQEVAL]: fix -WConversion warnings during compilation Aug 9, 2024
@pniedzielski pniedzielski self-requested a review August 9, 2024 18:52
@pniedzielski pniedzielski self-assigned this Aug 9, 2024
@pniedzielski pniedzielski added A-Broker Area: C++ Broker A-Client Area: C++ SDK labels Aug 9, 2024
@pniedzielski pniedzielski merged commit fc53abe into bloomberg:main Aug 9, 2024
29 checks passed
@pniedzielski
Copy link
Collaborator

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Broker Area: C++ Broker A-Client Area: C++ SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants