Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat[MQB]: track queue depth per appId #320

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

678098
Copy link
Collaborator

@678098 678098 commented Jun 12, 2024

  • Set queue stats to VirtualStorageCatalog on Primary and update per-appId queue metrics on these calls, if necessary
  • Do sort json stats on admin command
  • Add all the remaining queue metrics to json output
  • Regenerate queue stats IT expected data

@678098 678098 requested a review from a team as a code owner June 12, 2024 13:04
@678098 678098 force-pushed the t2360_appId_queue_depth_2 branch from 01396d3 to 9222a9a Compare July 5, 2024 17:38
@678098 678098 changed the title [WIP]Feat: track queue depth per appId Feat[MQB]: track queue depth per appId Jul 5, 2024
@678098 678098 force-pushed the t2360_appId_queue_depth_2 branch from 9222a9a to 90a7c9e Compare July 5, 2024 17:46
, d_opsPretty(bdljsn::WriteOptions()
.setSpacesPerLevel(4)
.setStyle(bdljsn::WriteStyle::e_PRETTY)
.setSortMembers(true))
Copy link
Collaborator Author

@678098 678098 Jul 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort is necessary to have less diff when we update sample json data in ITs
On the other hand, I can do this in ITs

@678098 678098 requested a review from kaikulimu July 5, 2024 17:50
@kaikulimu kaikulimu assigned dorjesinpo and unassigned kaikulimu Jul 5, 2024
@kaikulimu kaikulimu requested a review from dorjesinpo July 5, 2024 19:41
@678098 678098 force-pushed the t2360_appId_queue_depth_2 branch 4 times, most recently from 4f55f63 to 8ae6b9c Compare August 2, 2024 23:16
Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 187 of commit 102331e has completed with FAILURE

@678098 678098 force-pushed the t2360_appId_queue_depth_2 branch 5 times, most recently from 8252871 to 9644ed4 Compare October 3, 2024 14:59

return it->value()->confirm(&data->second);
return rc;
Copy link
Collaborator Author

@678098 678098 Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorjesinpo I checked your proposal to do this update in RootQueueEngine. The problem is that we don't expose message size (data->second.d_size) from this level (VirtualStorage/VirtualStorageCatalog) to the upper level of RootQueueEngine. Passing this up the exec stack will be harmful both for interfaces and performance.

Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 289 of commit 0ee07e5 has completed with FAILURE

if (!d_subContextsHolder.empty()) {
bsl::list<StatSubContextMp>::iterator it =
d_subContextsHolder.begin();
while (it != d_subContextsHolder.end()) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got rid of the loop in the put method and here it is back again.
At the moment, I do not see a good way to utilize VirtualStorageCatalog::numMessages so let's keep the loop.
Provided we won't maintain statistics for all Dynamic Apps.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check for empty d_subContextsHolder should be fast if we don't have subcontexts for dynamic apps.
We might utilize numMessages on the time when we do snapshot, but this change is more complex, since we don't have a good way to ensure that each and every virtual storage is alive, and this change is intrusive.
I would rather merge this PR for now, since it helps to test and compare queue metrics. We can think of this in the future, when we have prof outputs for the scenario in question.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I would also like to move metrics update code to the header and mark it inline, with hope that it will have less impact on performance. We have inline functions defined for StatContext, but we break the inline chain here when we define in .cpp. I would also like to do this change after we merge metrics update.

@678098 678098 merged commit 698d7be into bloomberg:main Oct 7, 2024
50 checks passed
@678098 678098 deleted the t2360_appId_queue_depth_2 branch October 7, 2024 20:31
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
Signed-off-by: Christopher Beard <[email protected]>

fixing Solaris build (bloomberg#434)

Signed-off-by: dorjesinpo <[email protected]>

Remove `-DBMQ_ENABLE_MSG_GROUPID` from the build system

We do not ever want to build with this flag when releasing, and users
often manage to enable this flag accidentally.  Because message group
IDs are not fully implemented, we remove this temporary definition.  It
can be added in later if we ever come back to this feature.

Signed-off-by: Patrick M. Niedzielski <[email protected]>

Make unit tests pass without `BMQ_ENABLE_MSG_GROUPID`

The unit tests currently assume that message group IDs are enabled, and
since have updated our build system to no longer enable this feature,
the unit tests now fail in CI.  This patch guards the message group ID
tests with preprocessor conditionals, disabling the parts of tests that
try to set and check message group IDs.  When `BMQ_ENABLE_MSG_GROUPID`
is set, these parts of the unit tests run again.

Signed-off-by: Patrick M. Niedzielski <[email protected]>

Fix mqbstat doc formatting (bloomberg#438)

Signed-off-by: Christopher Beard <[email protected]>

Fix[bmqeval]: limit expression length to avoid stack overflow (bloomberg#441)

Signed-off-by: Evgeny Malygin <[email protected]>

Fix Solaris unit tests (bloomberg#440)

Signed-off-by: Anton Pryakhin <[email protected]>

Docs[BMQ]: Use `.dox` files rather than `.md` files

Package group documentation in `libbmq` was converted to Markdown files
named `README.md`, and which was tied to the directory containing the
code for the package group using Doxygen `@dir` commands.  However, when
generating the documentation, this left several empty pages in the
documentation named `README`, which we were not able to remove.

The solution for this that this patch uses is to switch from `.md` files
to `.dox` files, which contain a single Doxygen-style C++ comment
containing the `@dir` command.  Unlike `.md` files, these do not
automatically create pages, so there is no empty `README` page created
for each package group.  The cost of this is that `.dox` files cannot be
simple Markdown files, but instead need to be wrapped in a C++ comment.

Signed-off-by: Patrick M. Niedzielski <[email protected]>

Docs[BMQ] bde -> doxygen conversion fixes (bloomberg#443)

* Doc[BMQT] minor bde -> doxygen docs

* Doc[BMQA] minor bde -> doxygen docs

* Doc[BMQA] re-wrap data member comments

* Doc[BMQT] re-wrap data member comments

* Apply suggestions from code review

---------

Signed-off-by: Christopher Beard <[email protected]>
Signed-off-by: Chris Beard <[email protected]>
Co-authored-by: Evgeny Malygin <[email protected]>

Feat: track queue depth per appId (bloomberg#320)

Signed-off-by: Evgeny Malygin <[email protected]>

configurator, bmqit: mode protos (bloomberg#447)

Signed-off-by: Jean-Louis Leroy <[email protected]>

Revert "configurator, bmqit: mode protos (bloomberg#447)" (bloomberg#449)

This reverts commit a4b20db.

Fix[mqbs_virtualstoragecatalog.cpp]: fix Solaris build (bloomberg#450)

Signed-off-by: Evgeny Malygin <[email protected]>

fix: configurator: apply app ids (bloomberg#452)

Signed-off-by: Jean-Louis Leroy <[email protected]>

Fix [MQB]: mqbc::StorageMgr: Transition to available only when all primary active (bloomberg#416)

* mqbc::StorageMgr: Ban 'processPrimaryStatusAdvisory' in non-FSM mode

Signed-off-by: Yuan Jing Vincent Yan <[email protected]>

* mqbc::StorageMgr: Transition to available only when all primary active

Signed-off-by: Yuan Jing Vincent Yan <[email protected]>

* mqbc::StorageMgr: clang-format

Signed-off-by: Yuan Jing Vincent Yan <[email protected]>

* mqbc::StorageMgr: Healing replica buffers primary status advisories

Signed-off-by: Yuan Jing Vincent Yan <[email protected]>

* mqbs::FileStore: Rename setPrimary -> setActivePrimary

Signed-off-by: Yuan Jing Vincent Yan <[email protected]>

* mqbc::StorageMgr: Comment about check if all partitions available

Signed-off-by: Yuan Jing Vincent Yan <[email protected]>

---------

Signed-off-by: Yuan Jing Vincent Yan <[email protected]>

Fix some compiler warnings in mqb (bloomberg#455)

* -Wunused-parameter
* -Wshadow
* -Wswitch-enum

Signed-off-by: Christopher Beard <[email protected]>

It: Include full path for admin stat it test failures (bloomberg#453)

* It: Include full path for admin stat it test failures

This patch makes it a little easier to debug the metric & operation that
causes an integration test for stats to fail.

Signed-off-by: Christopher Beard <[email protected]>

* Update src/integration-tests/test_admin_client.py

Co-authored-by: Evgeny Malygin <[email protected]>
Signed-off-by: Chris Beard <[email protected]>

---------

Signed-off-by: Christopher Beard <[email protected]>
Signed-off-by: Chris Beard <[email protected]>
Co-authored-by: Evgeny Malygin <[email protected]>

Feat: Add queue history size metric (bloomberg#436)

* [WIP] Feat: Add queue history size metric

This adds a new queue metric that counts the number of GUIDs in that
queue's history. This is useful for identifying excessive memory
utilization from history and potential history garbage collection issues
(where history is filled up faster than it's cleaned up).

Signed-off-by: Christopher Beard <[email protected]>

* It: Extend admin it for history size stat

Signed-off-by: Christopher Beard <[email protected]>

---------

Signed-off-by: Christopher Beard <[email protected]>

Feat[plugins]: report queue depth per appId to prometheus (bloomberg#446)

Signed-off-by: Evgeny Malygin <[email protected]>

[Fix] m_bmqstoragetool::FileManagerImpl: Asserts not have side effects (bloomberg#461)

Signed-off-by: Yuan Jing Vincent Yan <[email protected]>

Feat[MQB]: Enhance queue consumption monitor alarm log with additional details (bloomberg#420)

Enhance filebackedstorage alarm log

Signed-off-by: Aleksandr Ivanov <[email protected]>

Cleanup

Signed-off-by: Aleksandr Ivanov <[email protected]>

Add test to mqbu_capacitymeter.t

Signed-off-by: Aleksandr Ivanov <[email protected]>

mqbc::StorageUtil, mqbi::StorageMgr: updateQueue -> updateQueuePrimary (bloomberg#466)

Signed-off-by: Yuan Jing Vincent Yan <[email protected]>

Fix[MQB]: misc warnings (bloomberg#464)

Allow dots in subscription property names

Message properties allow arbitrary strings for property names, but our
subscription expression language is more limited, requiring an initial
alphabetic character followed by any number of alphanumeric characters
and underscores.  Some producers have begun using hierarchical message
property names, separated by dots (“.”), and are unable to use
subscriptions to filter or route according to these message properties.

This patch extends the expression language grammar to enable matching on
subscription property names with dots in them.  This change is a pure
extension: the language recognized by the subscription expression grammar
after this patch is a strict superset of the language recognized by the
subscription expression grammar before this patch.  This patch also
extends the unit test for the lexer to ensure this is a strict superset.

Signed-off-by: Patrick M. Niedzielski <[email protected]>

fix: clean app subscriptions on reconfigure

Signed-off-by: dorjesinpo <[email protected]>

Fix[mqbstat_domainstats.cpp]: empty tier StringRef (bloomberg#431)

Signed-off-by: Evgeny Malygin <[email protected]>

Fix Solaris build, it does not support ctor delegation

Signed-off-by: Aleksandr Ivanov <[email protected]>

Doc: Document app subscriptions (bloomberg#463)

* Docs upgrade jekyll -> 4.3.3

Signed-off-by: Christopher Beard <[email protected]>

* Docs: Document app subscriptions

Signed-off-by: Christopher Beard <[email protected]>

* Expand on difference in subscriptions

Signed-off-by: Christopher Beard <[email protected]>

* Minor subscription doc clarifications

Signed-off-by: Christopher Beard <[email protected]>

* Elaborate on subscription details

Signed-off-by: Christopher Beard <[email protected]>

* Clarify consumer subscription on broker

Signed-off-by: Christopher Beard <[email protected]>

---------

Signed-off-by: Christopher Beard <[email protected]>

fix: enhanced detection of duplciate PUSHes (bloomberg#472)

Signed-off-by: dorjesinpo <[email protected]>

Fix ntf-core version in build_darwin.sh

Signed-off-by: Aleksandr Ivanov <[email protected]>

Add logAppsSubscriptionInfoCb into InMemoryStorage

Signed-off-by: Aleksandr Ivanov <[email protected]>

Add IT for capacity meter enhanced log

Signed-off-by: Aleksandr Ivanov <[email protected]>

Fix comments

Signed-off-by: Aleksandr Ivanov <[email protected]>

Fix [CI] ntf-core version for macosx build (bloomberg#473)

Merge mwc into bmq

MWC or "MiddleWare Core" was a package group developed to support
a myriad of applications at Bloomberg. It's been useful to share
common middleware components between similar technologies, but doesn't
make much sense to support as its own open source library. Moving
forward we are merging it into the BMQ package group to better maintain
it for the BlazingMQ project.

Signed-off-by: Taylor Foxhall <[email protected]>

Fix conflict

Signed-off-by: Aleksandr Ivanov <[email protected]>

Fix conflict

Signed-off-by: Aleksandr Ivanov <[email protected]>

Fix mwctst

Signed-off-by: Aleksandr Ivanov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants