Fix: bmqp messageproperties Wconv warns #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Melvin He <[email protected]>
Signed-off-by: Melvin He <[email protected]>
alexander-e1off
pushed a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
Signed-off-by: Melvin He <[email protected]> Signed-off-by: Patrick M. Niedzielski <[email protected]>
alexander-e1off
pushed a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
Signed-off-by: Melvin He <[email protected]> Signed-off-by: Patrick M. Niedzielski <[email protected]>
alexander-e1off
pushed a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
Signed-off-by: Melvin He <[email protected]> Signed-off-by: Patrick M. Niedzielski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue number of the reported bug or feature request: #87 *
Describe your changes
This PR is straightforward, addressing several ‘-Wconversion‘ errors relating to ‘bmqp_messageproperties.cpp‘ as well as associated header and test files with appropriate casting.
Testing performed
Double-checked that there's no data loss or overflow for each update. We had either checked sizes with assertions beforehand or the term was originally constrained to be of a relatively small size.