Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WConversion warning #122

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Conversation

banipreetr
Copy link
Contributor

@banipreetr banipreetr commented Oct 5, 2023

*Issue number of the reported bug or feature request: #87 *

Describe your changes
This is a small good first issue contribution to fix -Wconversion warnings that pollutes the build log.

This particular PR deals with the following warning:

/home/runner/work/blazingmq/blazingmq/src/groups/mwc/mwctst/mwctst_blobtestutil.cpp:62:46: warning: conversion from ‘size_t’ {aka ‘long unsigned int’} to ‘int’ may change value [-Wconversion]
   62 |         bdlbb::BlobBuffer blobBuffer(buffer, length);

Testing performed
N/A
Additional context
Add any other context about your contribution here.

Signed-off-by: banipreetr <[email protected]>
@678098 678098 marked this pull request as ready for review October 8, 2023 09:37
@678098 678098 requested a review from a team as a code owner October 8, 2023 09:37
Copy link
Collaborator

@678098 678098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@678098 678098 merged commit a8335b7 into bloomberg:main Oct 8, 2023
6 checks passed
@678098
Copy link
Collaborator

678098 commented Oct 8, 2023

Hi @banipreetr! Sorry for the late reply, and thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants