Fix: bmqp messageproperties Wconv warns update

Signed-off-by: Melvin He <[email protected]>
bloomberg · May 6, 2024 · e88635b · e88635b
1 parent f2e7da8
commit e88635b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/groups/bmq/bmqp/bmqp_messageproperties.h b/src/groups/bmq/bmqp/bmqp_messageproperties.h
@@ -654,8 +654,8 @@ MessageProperties::setProperty(const bsl::string& name, const TYPE& value)
         d_isDirty = true;
     }
     else {
-        delta += static_cast<int>(name.length()) +
-                 sizeof(MessagePropertyHeader);
+        delta += static_cast<int>(name.length() +
+                                  sizeof(MessagePropertyHeader));
         if (0 == numProperties()) {
             // If its the 1st property, also include the size of struct
             // 'MessagePropertiesHeader'.

diff --git a/src/groups/bmq/bmqp/bmqp_messageproperties.t.cpp b/src/groups/bmq/bmqp/bmqp_messageproperties.t.cpp
@@ -418,7 +418,7 @@ void encode(bdlbb::Blob* blob, const PropertyMap& pmap)
         bmqp::MessagePropertyHeader        mph;
         mph.setPropertyType(tsvPair.first.first);
         mph.setPropertyNameLength(static_cast<int>(cit->first.length()));
-        mph.setPropertyValueLength(tsvPair.first.second);
+        mph.setPropertyValueLength(static_cast<int>(tsvPair.first.second));
 
         bdlbb::BlobUtil::append(blob,
                                 reinterpret_cast<const char*>(&mph),
@@ -429,7 +429,9 @@ void encode(bdlbb::Blob* blob, const PropertyMap& pmap)
     // Second pass.
     for (PropertyMapConstIter cit = pmap.begin(); cit != pmap.end(); ++cit) {
         const PropertyTypeSizeVariantPair& tsvPair = cit->second;
-        bdlbb::BlobUtil::append(blob, cit->first.c_str(), cit->first.length());
+        bdlbb::BlobUtil::append(blob,
+                                cit->first.c_str(),
+                                static_cast<int>(cit->first.length()));
         totalSize += static_cast<int>(cit->first.length());
 
         PropertyValueStreamOutVisitor visitor(blob);