Reduce network by only fetching block meta instead of whole block #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godmodegalactus
requested changes
Jan 8, 2024
| _ = cleanup_tick.tick() => { | ||
| let size_before = recent_confirmed_blocks.len(); | ||
| recent_confirmed_blocks.retain(|_blockhash, block| { | ||
| block.slot > current_slot - 100 // must be greater than finalized slot distance (32) |
There was a problem hiding this comment.
Not a good idea, In some cases it takes time to finalize like if there are some complicated bank forks. So current_slot should be last_finalized_slot
There was a problem hiding this comment.
ah! very good point. my logic was very wrong.
There was a problem hiding this comment.
should be fixed now
godmodegalactus
previously approved these changes
Jan 8, 2024
godmodegalactus
dismissed
their stale review
The merge-base changed after approval.
godmodegalactus
previously approved these changes
Jan 11, 2024
grooviegermanikus
dismissed
godmodegalactus’s stale review
The merge-base changed after approval.
godmodegalactus
deleted the
reducing_network_usage_by_fetching_only_finalized_blockmeta-groovie
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes: