Update grpc version to 0.11.0 so that we can use the latest triton se… #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godmodegalactus
force-pushed
the
gmg/update_grpc_version
branch
from
a00c4e5 to
e6d2ab8
Compare
musitdev
approved these changes
Nov 14, 2023
| @@ -60,5 +60,5 @@ solana-lite-rpc-cluster-endpoints = {path = "cluster-endpoints", version="0.2.3" | |||
| solana-lite-rpc-history = {path = "history", version="0.2.3"} | |||
|
|
|||
| async-trait = "0.1.68" | |||
| yellowstone-grpc-client = "1.9.0" | |||
| yellowstone-grpc-proto = "1.9.0" | |||
| yellowstone-grpc-client = "1.11.0" | |||
There was a problem hiding this comment.
I wonder how the project's git tagging system works?
how do we know if we getv1.11.0+solana.1.17.4 vs v1.11.0+solana.1.16.17?
There was a problem hiding this comment.
Yes it is quite difficult to know with grpc plugin i agree. I think it depends on solana grpc plugin. If it was compiled with solana 1.17.4 or with v1.11.0 because anyways we want to get what is the version of grpc on the solana validator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rvice