2.0.16 #13
2.0.16 #13
Conversation
ghost
There was a problem hiding this comment.
I think it is missing some optimizations about the buffer sizes that groovie did.
@grooviegermanikus Could you check. Other than LGTM.
Cargo.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "geyser-grpc-connector" | |||
| version = "0.10.1+yellowstone.1.12" | |||
| version = "2.0.0" | |||
There was a problem hiding this comment.
should have same naming convention
There was a problem hiding this comment.
Can you eleborate on this naming convention - I don't understand what 0.10.1+yellowstone.1.12 means
There was a problem hiding this comment.
0.10.1 is the version of the connector. "1.12" is the yellowstone-proto (protobuf) wire format version
There was a problem hiding this comment.
Okay that sounds like we want 0.11.0+yellowstone.2.0.0 for this
There was a problem hiding this comment.
would prefer 0.11.0+solana-2.0.16 or 0.11.0+yellowstone-2.0.0+solana-2.0.16, the solana dependency is the main thing people will want to look out for when using this package, but if there's a good reason for yellowstone tags, then let's do both. yellowstone-2.0.0 unfortunately supports many solana versions
| @@ -32,6 +31,20 @@ bincode = "1.3.3" | |||
|
|
|||
| csv = "1.3.0" | |||
|
|
|||
| dashmap = "5.5.3" | |||
|
|
|||
| tonic = { version= "0.12.3", features=["gzip"] } | |||
There was a problem hiding this comment.
tonic dependency had some historic version issues. do we need that here?
There was a problem hiding this comment.
@grooviegermanikus - I think those dependencies cam from your performancetest branch - I just updated tonic to most recent - we need this to enable gzip in yellowstone_grpc_util
GeyserClient::with_interceptor(channel, interceptor)
.accept_compressed(CompressionEncoding::Gzip)There was a problem hiding this comment.
lets move forward, i found a workaround for the zeroize version issue.
There was a problem hiding this comment.
you can drop Gzip support if it helps
|
I updated traffic and can confirm this does build, we should merge this branch, once we verified the whole integration traffic + connector + grpc + rpc 2.0.16 works. Sent @mango-dee creds for setting up a fresh rpc in frankfurt. |
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "geyser-grpc-connector" | |||
| version = "0.10.1+yellowstone.1.12" | |||
| version = "0.11.0+yellowstone.2.0.0" | |||
There was a problem hiding this comment.
Yellowstone proto is 1.15 not 2.0.0 afaik
No description provided.