Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(stats):remove resolution dep #1069

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

refactor(stats):remove resolution dep #1069

wants to merge 6 commits into from

Conversation

yjhmelody
Copy link
Contributor

@yjhmelody yjhmelody commented Sep 27, 2024 •
edited
Loading

Seems not a useful design.
The tuple impls of DataSource could replace this part.
@bragov4ik any problem?

@bragov4ik
Copy link
Contributor

bragov4ik commented Oct 8, 2024 •
edited
Loading

Overall it makes sense, though I think it's better to rename MainDependencies after this. I'll need some time to think this through if there are any problems; so I'll return to it later when I'll have some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yjhmelody @bragov4ik