Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(launcher): RequestIdStorage fixes #1014

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

bragov4ik
Copy link
Contributor

@bragov4ik bragov4ik commented Aug 15, 2024

  • Fix the layer overwriting fields of handled spans (due to setting extensions to some value which are prioritized over any fields)
  • Add unit test to check it
  • Clippy fixes

@bragov4ik bragov4ik force-pushed the bragov4ik/launcher-fix-span-field-overwrite branch 2 times, most recently from 088d2a9 to 32a9c1a Compare August 16, 2024 07:50
@bragov4ik bragov4ik marked this pull request as ready for review August 16, 2024 07:56
Copy link
Member

@rimrakhimov rimrakhimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please briefly describe how your solution fixes the problem?

@bragov4ik bragov4ik force-pushed the bragov4ik/launcher-fix-span-field-overwrite branch from fd02db4 to 020031a Compare August 21, 2024 09:54
@bragov4ik bragov4ik merged commit 1a8bbd3 into main Aug 21, 2024
1 of 2 checks passed
@bragov4ik bragov4ik deleted the bragov4ik/launcher-fix-span-field-overwrite branch August 21, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants