Remove use of init container #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should be able to merge this PR and it will close #7 since it's changes are included. |
|
@brujoand please rebase this and update the chart version to 6.0.0 Thanks! |
|
ah, sorry I completely forgot about this one. Back in sync with master now, but looking over this I'm not sure why I renamed the persistant storage to media. I'll change that back to data. Edit: Ah that was because of #7 which we dropped. |
brujoand
force-pushed
the
remove_use_of_init_container
branch
from
064aa6e to
d0508fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the custom mask and init container. Not as sure about this one but had to push before the kids get back from skiing! ref #6 I can test it later tonight.
And I'm basing this PR on top of the previous one to avoid conflict, not sure how that's going to look but hopefully fine when/if #7 is merged.