Update TinySTL. #340
Merged
Update TinySTL. #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkaradzic
added a commit
that referenced
this pull request
Jan 26, 2025
This reverts commit 2a03cec.
|
Latest version causes crash when cycling thru examples in bgfx. Please test with bgfx. |
|
Submitting PR fix for theoretical undefined behavior, and introducing crash is not what we want... |
|
That's why I stated clearly what I tested and what not. I'm now back on my main development machine. Will investigate! |
mcourteaux
commented
Jan 27, 2025
| : m_size(0) | ||
| { | ||
| buffer_init<pointer, Alloc>(&m_buckets); | ||
| buffer_resize<pointer, Alloc>(&m_buckets, 9, 0); |
There was a problem hiding this comment.
@bkaradzic The crash you were seeing is due to this line being removed. I found the offending commit:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested this in the following ways:
I did not test (neither compile, nor run):
While working on this update, I reported: