Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: BGFX_TEXTURE_MSAA_SAMPLE and msaa sampling bugs with gl #3351

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixed: BGFX_TEXTURE_MSAA_SAMPLE and msaa sampling bugs with gl #3351

wants to merge 4 commits into from

Commits on Sep 9, 2024

  1. fixed: multiple BGFX_TEXTURE_MSAA_SAMPLE attachments could not be pre… 

    …sent in a framebuffer at once (sample locations were not fixed)

I've just set the sample location as always fixed for now, although technically this can be false if only 1 msaa texture attachment is present
    @ProPuke
    ProPuke committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    96d6e3b View commit details
    Browse the repository at this point in the history

  2. fixed: framebuffer with a resolved msaa AND a sample msaa at the same… 

    … time would result in an invalid framebuffer

it would try to also resolve the sample-msaa texture at the same, leading to an invalid target type
    @ProPuke
    ProPuke committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    a4d7a4d View commit details
    Browse the repository at this point in the history

  3. fixed: depth attachments could not be sample-msaa 

    this is valid, they don't resolving
    @ProPuke
    ProPuke committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ef4bc18 View commit details
    Browse the repository at this point in the history

  4. fixed: shader error sampking msaa textures in gl 

    parameter duplication on texelFetch(sampler2DMS,*) led to failed shaders
    @ProPuke
    ProPuke committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    e0b73d7 View commit details
    Browse the repository at this point in the history