Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metal): clear only bound textures #3310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Jun 20, 2024

  1. fix(metal): clear only bound textures

    `clearQuad()` can be operating on framebuffers that don't have all the
    color/depth/stencil buffers attached.
    
    For example, if there is no stencil buffer in the framebuffer, the Metal
    driver asserts with:
    
    ```
    validateDepthStencilState: failed assertion `MTLDepthStencilDescriptor uses
    frontFaceStencil but MTLRenderPassDescriptor has a nil stencilAttachment
    texture'
    ```
    
    Copy the logic from `setFrameBuffer()` to check which buffers we can clear.
    Using this info set the pipeline state that is valid for currently bound
    buffers.
    blaztinn authored and blaztomazicO7 committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    628d98c View commit details
    Browse the repository at this point in the history