Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve c sharp binding generation #3261

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Feb 28, 2024

  1. Improve c sharp binding generation

    - Enums of type byte were not implemented, only uint and ushort were recognised.
    - Added XML comments to the structs, and their fields.
    - Added default values to parameters
     - For the handles, it was not possible to have Invalid as a default parameter. Instead i emit another method without the argument, that calls the `extern` with an Invalid handle.
     This also required some overhauling for those structs, and i've also implemented some recommended fields to improve performance (https://learn.microsoft.com/en-us/visualstudio/ide/reference/generate-equals-structs?view=vs-2022).
    TJHeuvel committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    0e9ee9f View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Revert iquatable and method overrides on structs

    These caused more friction than intended. Only the `Invalid` readonly field remains, and a constructor that includes the index parameter are additions.
    TJHeuvel committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    69fe2ec View commit details
    Browse the repository at this point in the history