Enable debug information for Metal shaders

bkaradzic · Nov 6, 2023 · 8786426 · 8786426
1 parent 257de75
commit 8786426
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/docs/tools.rst b/docs/tools.rst
@@ -199,7 +199,7 @@ Options:
   --varyingdef <file path>  A varying.def.sc's file path.
   --verbose                 Be verbose.
 
-(Vulkan and DirectX):
+(Vulkan, DirectX and Metal):
 
   --debug                   Debug information.
 

diff --git a/tools/shaderc/shaderc.cpp b/tools/shaderc/shaderc.cpp
@@ -1054,7 +1054,7 @@ namespace bgfx
 			  "      --verbose                 Be verbose.\n"
 
 			  "\n"
-			  "(Vulkan and DirectX):\n"
+			  "(Vulkan, DirectX and Metal):\n"
 
 			  "\n"
 			  "      --debug                   Debug information.\n"

diff --git a/tools/shaderc/shaderc_metal.cpp b/tools/shaderc/shaderc_metal.cpp
@@ -286,6 +286,7 @@ namespace bgfx { namespace metal
 			| EShMsgReadHlsl
 			| EShMsgVulkanRules
 			| EShMsgSpvRules
+			| EShMsgDebugInfo
 			);
 
 		shader->setEntryPoint("main");
@@ -494,7 +495,10 @@ namespace bgfx { namespace metal
 				std::vector<uint32_t> spirv;
 
 				glslang::SpvOptions options;
-				options.disableOptimizer = false;
+				options.disableOptimizer = _options.debugInformation;
+				options.generateDebugInfo = _options.debugInformation;
+				options.emitNonSemanticShaderDebugInfo = _options.debugInformation;
+				options.emitNonSemanticShaderDebugSource = _options.debugInformation;
 
 				glslang::GlslangToSpv(*intermediate, spirv, &options);