Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide buttons after submission deadline is passed if form is not editable #646

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

dreamfall
Copy link
Contributor

📝 A short description of the changes

  • previously we showed the buttons allowing user in theory to bypass the validations and add 3rd letter of support

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

@dreamfall dreamfall merged commit 4efa279 into main Feb 1, 2024
3 checks passed
@dreamfall dreamfall deleted the letters-of-support-post-deadline-edit branch February 1, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants