add ability to remove letter of support right after upload #2909
dreamfallAnnotations
10 errors and 10 warnings
|
test:
spec/controllers/admin/assessment_submissions_controller_spec.rb#L13
Admin::AssessmentSubmissionsController POST create should create a resource
Failure/Error:
struct.rates(form_answer, rate_type).each do |section, _|
val = section_rate(section)
c = "#{rate_type.upcase}_ALLOWED_VALUES"
if val && !struct.const_get(c).include?(val)
sect_name = struct.rate(section)
errors.add(sect_name, "#{rate_type} field has not permitted value")
end
NameError:
uninitialized constant AppraisalForm::QAVS_2025
|
|
test:
spec/controllers/admin/assessment_submissions_controller_spec.rb#L21
Admin::AssessmentSubmissionsController PATCH unlonk should unlock a resource
Failure/Error:
struct.rates(form_answer, rate_type).each do |section, _|
val = section_rate(section)
c = "#{rate_type.upcase}_ALLOWED_VALUES"
if val && !struct.const_get(c).include?(val)
sect_name = struct.rate(section)
errors.add(sect_name, "#{rate_type} field has not permitted value")
end
NameError:
uninitialized constant AppraisalForm::QAVS_2025
|
|
test:
spec/controllers/assessor/assessment_submissions_controller_spec.rb#L15
Assessor::AssessmentSubmissionsController POST create should create a resource
Failure/Error:
struct.rates(form_answer, rate_type).each do |section, _|
val = section_rate(section)
c = "#{rate_type.upcase}_ALLOWED_VALUES"
if val && !struct.const_get(c).include?(val)
sect_name = struct.rate(section)
errors.add(sect_name, "#{rate_type} field has not permitted value")
end
NameError:
uninitialized constant AppraisalForm::QAVS_2025
|
|
test:
spec/factories_spec.rb#L5
assessor_assignment factory should be valid
Failure/Error:
struct.rates(form_answer, rate_type).each do |section, _|
val = section_rate(section)
c = "#{rate_type.upcase}_ALLOWED_VALUES"
if val && !struct.const_get(c).include?(val)
sect_name = struct.rate(section)
errors.add(sect_name, "#{rate_type} field has not permitted value")
end
NameError:
uninitialized constant AppraisalForm::QAVS_2025
|
|
test:
spec/support/shared_contexts/appraisal_form_context.rb#L11
Admin submits appraisal form
As Admin
I want to be able to edit, submit the appraisal form.
behaves like successful appraisal form edition Evaluation change updates the evaluation rate and description
Failure/Error:
AppraisalForm.struct(form_answer, f).map do |k, section|
section_obj = OpenStruct.new(section.merge(desc: "#{k}_desc", rate: "#{k}_rate"))
partial = "admin/form_answers/appraisal_form_components/#{section[:type]}_section"
section_odd_even = !section_odd_even
render partial: partial, locals: { section: section_obj, f: f, section_odd_even: section_odd_even }
end.join.html_safe
ActionView::Template::Error:
uninitialized constant AppraisalForm::QAVS_2025
Shared Example Group: "successful appraisal form edition" called from ./spec/features/admin/form_answers/appraisal_form_submission_spec.rb:15
|
|
test:
spec/support/shared_contexts/appraisal_form_context.rb#L17
Admin submits appraisal form
As Admin
I want to be able to edit, submit the appraisal form.
behaves like successful appraisal form edition Overall verdict change updates verdict
Failure/Error:
AppraisalForm.struct(form_answer, f).map do |k, section|
section_obj = OpenStruct.new(section.merge(desc: "#{k}_desc", rate: "#{k}_rate"))
partial = "admin/form_answers/appraisal_form_components/#{section[:type]}_section"
section_odd_even = !section_odd_even
render partial: partial, locals: { section: section_obj, f: f, section_odd_even: section_odd_even }
end.join.html_safe
ActionView::Template::Error:
uninitialized constant AppraisalForm::QAVS_2025
Shared Example Group: "successful appraisal form edition" called from ./spec/features/admin/form_answers/appraisal_form_submission_spec.rb:15
|
|
test:
spec/support/shared_contexts/appraisal_form_context.rb#L24
Admin submits appraisal form
As Admin
I want to be able to edit, submit the appraisal form.
behaves like successful appraisal form edition submission fills in the form and submits
Failure/Error:
AppraisalForm.struct(form_answer, f).map do |k, section|
section_obj = OpenStruct.new(section.merge(desc: "#{k}_desc", rate: "#{k}_rate"))
partial = "admin/form_answers/appraisal_form_components/#{section[:type]}_section"
section_odd_even = !section_odd_even
render partial: partial, locals: { section: section_obj, f: f, section_odd_even: section_odd_even }
end.join.html_safe
ActionView::Template::Error:
uninitialized constant AppraisalForm::QAVS_2025
Shared Example Group: "successful appraisal form edition" called from ./spec/features/admin/form_answers/appraisal_form_submission_spec.rb:15
|
|
test:
spec/support/shared_contexts/appraisal_form_context.rb#L11
Assessor submits appraisal form
As Assessor
I want to be able to edit, submit the appraisal form.
behaves like successful appraisal form edition Evaluation change updates the evaluation rate and description
Failure/Error:
AppraisalForm.struct(form_answer, f).map do |k, section|
section_obj = OpenStruct.new(section.merge(desc: "#{k}_desc", rate: "#{k}_rate"))
partial = "admin/form_answers/appraisal_form_components/#{section[:type]}_section"
section_odd_even = !section_odd_even
render partial: partial, locals: { section: section_obj, f: f, section_odd_even: section_odd_even }
end.join.html_safe
ActionView::Template::Error:
uninitialized constant AppraisalForm::QAVS_2025
Shared Example Group: "successful appraisal form edition" called from ./spec/features/assessor/appraisal_form_submission_spec.rb:16
|
|
test:
spec/support/shared_contexts/appraisal_form_context.rb#L17
Assessor submits appraisal form
As Assessor
I want to be able to edit, submit the appraisal form.
behaves like successful appraisal form edition Overall verdict change updates verdict
Failure/Error:
AppraisalForm.struct(form_answer, f).map do |k, section|
section_obj = OpenStruct.new(section.merge(desc: "#{k}_desc", rate: "#{k}_rate"))
partial = "admin/form_answers/appraisal_form_components/#{section[:type]}_section"
section_odd_even = !section_odd_even
render partial: partial, locals: { section: section_obj, f: f, section_odd_even: section_odd_even }
end.join.html_safe
ActionView::Template::Error:
uninitialized constant AppraisalForm::QAVS_2025
Shared Example Group: "successful appraisal form edition" called from ./spec/features/assessor/appraisal_form_submission_spec.rb:16
|
|
test:
spec/support/shared_contexts/appraisal_form_context.rb#L24
Assessor submits appraisal form
As Assessor
I want to be able to edit, submit the appraisal form.
behaves like successful appraisal form edition submission fills in the form and submits
Failure/Error:
AppraisalForm.struct(form_answer, f).map do |k, section|
section_obj = OpenStruct.new(section.merge(desc: "#{k}_desc", rate: "#{k}_rate"))
partial = "admin/form_answers/appraisal_form_components/#{section[:type]}_section"
section_odd_even = !section_odd_even
render partial: partial, locals: { section: section_obj, f: f, section_odd_even: section_odd_even }
end.join.html_safe
ActionView::Template::Error:
uninitialized constant AppraisalForm::QAVS_2025
Shared Example Group: "successful appraisal form edition" called from ./spec/features/assessor/appraisal_form_submission_spec.rb:16
|
|
test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/cache@v2, actions/setup-node@v2-beta, nanasess/setup-chromedriver@master. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2, actions/setup-node@v2-beta. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
test:
spec/controllers/assessor/reports_controller_spec.rb#L12
Assessor::ReportsController GET index
Failure/Error:
it "should render template" do
get :index
expect(response).to render_template("index")
end
`it` is not available from within an example (e.g. an `it` block) or from constructs that run in the scope of an example (e.g. `before`, `let`, etc). It is only available on an example group (e.g. a `describe` or `context` block).
|
|
test:
spec/controllers/assessor/reports_controller_spec.rb#L19
Assessor::ReportsController GET show
Failure/Error:
it "renders the show template" do
get :show, params: { id: 'feedbacks', category: 'trade' }, :format => 'pdf'
expect(response.content_type).to eq('application/pdf')
get :show, params: { id: 'case_summaries',category: 'trade' }, :format => 'csv'
expect(response.content_type).to eq('text/csv')
end
`it` is not available from within an example (e.g. an `it` block) or from constructs that run in the scope of an example (e.g. `before`, `let`, etc). It is only available on an example group (e.g. a `describe` or `context` block).
|
|
test:
spec/features/assessor/fulfills_the_draft_notes_spec.rb#L16
Assessor fulfills the draft notes. fulfills the draft notes form
Failure/Error: @form_answer ||= current_assessor.applications_scope(@award_year).find(params[:id]).decorate
ActiveRecord::RecordNotFound:
Couldn't find FormAnswer with 'id'=1 [WHERE "form_answers"."award_year_id" = $1 AND "form_answers"."state" IN ($2, $3, $4, $5, $6, $7, $8) AND "form_answers"."sub_group" = $9]
|
|
test:
spec/validators/advanced_email_validator_spec.rb#L49
AdvancedEmailValidator allows correct e-mail addresses
|
|
test:
spec/validators/advanced_email_validator_spec.rb#L61
AdvancedEmailValidator DNS checks for domain checks for the existence of an MX record for the domain
|
|
test:
spec/validators/advanced_email_validator_spec.rb#L70
AdvancedEmailValidator DNS checks for domain doesn't return an error when the MX lookup timed out
|
|
test:
spec/validators/advanced_email_validator_spec.rb#L95
AdvancedEmailValidator bounced addresses prevents validation on an e-mail address marked as bounced in sendgrid
|
|
test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|