Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reports::CsvHelper#find_each_with_order #3167

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

phil-l-brockwell
Copy link
Contributor

@phil-l-brockwell phil-l-brockwell commented Jan 6, 2025

πŸ“ A short description of the changes

  • Add a method which returns db records in batches and respects the existing order

πŸ”— Link to the relevant story (or stories)

βœ… Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

@phil-l-brockwell phil-l-brockwell marked this pull request as ready for review January 7, 2025 14:27
@phil-l-brockwell phil-l-brockwell force-pushed the pb/fix-report-ordering branch 3 times, most recently from e64905e to 4d21385 Compare January 8, 2025 11:46
@phil-l-brockwell phil-l-brockwell merged commit c0b8435 into main Jan 13, 2025
9 checks passed
@phil-l-brockwell phil-l-brockwell deleted the pb/fix-report-ordering branch January 13, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants