Add an endpoint to get policy status #5049
Open
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5049 +/- ##
==========================================
- Coverage 43.06% 43.05% -0.01%
==========================================
Files 1412 1412
Lines 64775 64784 +9
Branches 5920 5922 +2
==========================================
Hits 27894 27894
- Misses 35649 35658 +9
Partials 1232 1232 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
No New Or Fixed Issues Found |
r-tome
reviewed
Nov 20, 2024
| @@ -85,6 +85,23 @@ public async Task<PolicyDetailResponseModel> Get(Guid orgId, int type) | |||
| return new PolicyDetailResponseModel(policy); | |||
| } | |||
|
|
|||
| [HttpGet("{type}/policy-status")] | |||
| public async Task<bool> GetPolicyStatusAsync(Guid orgId, int type) | |||
There was a problem hiding this comment.
Why not use PolicyType type directly?
Suggested change
| public async Task<bool> GetPolicyStatusAsync(Guid orgId, int type) | |
| public async Task<bool> GetPolicyStatusAsync(Guid orgId, PolicyType type) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13347
📔 Objective
When the Remove Bitwarden Families policy is on, the product will follow the following behaviors depending on the # of organizations the user is part of.
Individual vault impacts - Scenario 1
Given the users email address is only associated with 1 enterprise organization, when the policy is turned on, then hide the Free Bitwarden Families page from the navigation
Individual vault impacts - Scenario 2
Given the email address is associated with multiple enterprise organization, the policy is turned on, and my sponsorship is status is active, when the user attempts to interact with the three dot menu, then the only option is to remove the sponsorship
Individual vault impacts - Scenario 3
Given the email address is associated with multiple enterprise organization, the policy is turned on, and my sponsorship is status is sent, when the user attempts to interact with the three dot menu, then the only option is to remove the sponsorship and we hide the Resend email option
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes