Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15048] Update bank account verification to use descriptor code #5048

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

amorask-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15048

📔 Objective

Updates the bank account verification functionality behind the Stripe Sources API deprecation flag to use Stripe's updated statement descriptor verification approach.

📸 Screenshots

Screen.Recording.2024-11-19.at.1.38.50.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@amorask-bitwarden amorask-bitwarden requested a review from a team as a code owner November 19, 2024 18:40
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 46.87500% with 17 lines in your changes missing coverage. Please review.

Project coverage is 43.04%. Comparing base (5227ee7) to head (a4a37b1).

Files with missing lines Patch % Lines
...ling/Services/Implementations/SubscriberService.cs 53.84% 12 Missing ⚠️
...lling/Controllers/OrganizationBillingController.cs 0.00% 4 Missing ⚠️
...ng/Models/Requests/VerifyBankAccountRequestBody.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5048      +/-   ##
==========================================
- Coverage   43.05%   43.04%   -0.02%     
==========================================
  Files        1412     1412              
  Lines       64769    64781      +12     
  Branches     5919     5923       +4     
==========================================
- Hits        27887    27883       -4     
- Misses      35649    35665      +16     
  Partials     1233     1233              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

github-actions bot commented Nov 19, 2024

Logo
Checkmarx One – Scan Summary & Details19be2c6d-8404-402c-874c-db443830d852

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/Auth/Controllers/TwoFactorController.cs: 258 Attack Vector
LOW Missing_CSP_Header /src/Core/MailTemplates/Handlebars/FamiliesForEnterprise/FamiliesForEnterpriseRemovedFromFamilyUser.html.hbs: 5 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/MembersController.cs: 95
MEDIUM CSRF /src/Api/Billing/Controllers/OrganizationSponsorshipsController.cs: 77
MEDIUM CSRF /src/Api/Billing/Controllers/OrganizationSponsorshipsController.cs: 163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant