-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-13746] Remove loggedInUserId parameter. #5033
[PM-13746] Remove loggedInUserId parameter. #5033
Conversation
1. The calling code never passed in a loggedInUserId. \n2. Update/remove tests.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5033 +/- ##
==========================================
- Coverage 42.67% 42.67% -0.01%
==========================================
Files 1406 1406
Lines 65091 65075 -16
Branches 5969 5967 -2
==========================================
- Hits 27777 27770 -7
+ Misses 36070 36060 -10
- Partials 1244 1245 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Please link the ticket url in the PR description https://bitwarden.atlassian.net/browse/PM-13746
I'm reading through the process to see if it's safe to merge. |
I'm going to merge this in Tuesday after a new rc is cut. |
@JimmyVo16, when its behind a feature flag we merge it to main and the QA team test it there. In cases like this one, because its not gated behind a feature flag, we ask the QA team to test using the feaure branch |
Update: QA successfully tested this on the feature branch. |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13746
📔 Objective
_organizationService.ValidateOrganizationUserUpdatePermissions
since it is not needed for updating group associations.loggedInUserId
since it's no longer needed.📸 Screenshots
The unit test pretty much covers it, but here is a manual test for a sanity check.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes