Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13746] Remove loggedInUserId parameter. #5033

Merged

Conversation

JimmyVo16
Copy link
Contributor

@JimmyVo16 JimmyVo16 commented Nov 12, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13746

📔 Objective

  1. Remove _organizationService.ValidateOrganizationUserUpdatePermissions since it is not needed for updating group associations.
  2. Remove loggedInUserId since it's no longer needed.
  3. Update/remove related tests.

📸 Screenshots

The unit test pretty much covers it, but here is a manual test for a sanity check.

image image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

1. The calling code never passed in a loggedInUserId. \n2. Update/remove tests.
@JimmyVo16 JimmyVo16 requested a review from a team as a code owner November 12, 2024 20:42
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 42.67%. Comparing base (a26ba3b) to head (f6e0cfd).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...minConsole/Public/Controllers/MembersController.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5033      +/-   ##
==========================================
- Coverage   42.67%   42.67%   -0.01%     
==========================================
  Files        1406     1406              
  Lines       65091    65075      -16     
  Branches     5969     5967       -2     
==========================================
- Hits        27777    27770       -7     
+ Misses      36070    36060      -10     
- Partials     1244     1245       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details2be6b950-bb30-42c9-8e61-a26d05733557

No New Or Fixed Issues Found

Copy link
Contributor

@r-tome r-tome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Please link the ticket url in the PR description https://bitwarden.atlassian.net/browse/PM-13746

@JimmyVo16
Copy link
Contributor Author

I'm reading through the process to see if it's safe to merge.

@JimmyVo16
Copy link
Contributor Author

I'm reading through the process to see if it's safe to merge.

I'm going to merge this in Tuesday after a new rc is cut.

@r-tome
Copy link
Contributor

r-tome commented Nov 18, 2024

@JimmyVo16, when its behind a feature flag we merge it to main and the QA team test it there. In cases like this one, because its not gated behind a feature flag, we ask the QA team to test using the feaure branch

@JimmyVo16
Copy link
Contributor Author

Update: QA successfully tested this on the feature branch.

@JimmyVo16 JimmyVo16 merged commit 5227ee7 into main Nov 19, 2024
95 of 96 checks passed
@JimmyVo16 JimmyVo16 deleted the PM-13746-fix-UpdateOrganizationUserGroupsCommand-logic branch November 19, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants