Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14798] Update ProviderEventService for multi-organization enterprises #5026

Conversation

jonashendrickx
Copy link
Member

@jonashendrickx jonashendrickx commented Nov 12, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14798

📔 Objective

Just refactored the ProviderEventService to support the new provider type. The validation should have already been completed elsewhere for assigned specific plans with each provider type, which can simplify the code quite a bit.

Or should we keep these extra lines of validation to detect any corruption before it has caused enough trouble?

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jonashendrickx jonashendrickx requested a review from a team as a code owner November 12, 2024 09:40
@jonashendrickx jonashendrickx marked this pull request as draft November 12, 2024 09:51
Copy link
Contributor

github-actions bot commented Nov 12, 2024

Logo
Checkmarx One – Scan Summary & Details8c330772-b633-44af-9b5b-8e4093b18b58

No New Or Fixed Issues Found

@jonashendrickx jonashendrickx marked this pull request as ready for review November 12, 2024 12:17
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 42.56%. Comparing base (702a81b) to head (0c5844d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...g/Services/Implementations/ProviderEventService.cs 72.00% 2 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5026      +/-   ##
==========================================
- Coverage   42.58%   42.56%   -0.03%     
==========================================
  Files        1406     1406              
  Lines       65074    65052      -22     
  Branches     5962     5962              
==========================================
- Hits        27715    27691      -24     
- Misses      36131    36133       +2     
  Partials     1228     1228              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonashendrickx jonashendrickx merged commit 25afd50 into main Nov 12, 2024
52 checks passed
@jonashendrickx jonashendrickx deleted the PM-14798-Billing-Update-ProviderEventService-to-support-Multi-organization-enterprises branch November 12, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants