[PM-13843] Optimize collectioncipher readbyuserid #4916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4916 +/- ##
=======================================
Coverage 41.79% 41.79%
=======================================
Files 1364 1364
Lines 64003 64003
Branches 5871 5871
=======================================
Hits 26751 26751
Misses 36048 36048
Partials 1204 1204 ☔ View full report in Codecov by Sentry. |
rkac-bw
changed the title
rkac-bw
changed the title
|
No New Or Fixed Issues Found |
rkac-bw
changed the title
withinfocus
requested changes
Oct 18, 2024
| WHERE | ||
| OU.[Status] = 2 | ||
| AND CU.[CollectionId] IS NULL | ||
| END |
There was a problem hiding this comment.
⛏️ Newline at the end.
withinfocus
approved these changes
Oct 18, 2024
cyprain-okeke
pushed a commit
that referenced
this pull request
Oct 30, 2024
* Optimise stored procedure Collectioncipher_ReadByUserId * Optimise stored procedure Collectioncipher_ReadByUserId * Optimise stored procedure Collectioncipher_ReadByUserId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13843
📔 Objective
Database Optimization:
Stored procedure [Collectioncipher_ReadByUserId] has regressed in performance and is affecting CPU usage greatly. It has been rewritten to just use inner joins and a union all to maximize index usage.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes