Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-2025] Add Organization.FlexibleCollections to database and sprocs #3642

Conversation

eliykat
Copy link
Member

@eliykat eliykat commented Jan 4, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

  • Add a new property/column, Organization.FlexibleCollections. This will replace the FlexibleCollections (MVP) LaunchDarkly feature flag for toggling app behaviour. It defaults to false. The intention is to allow individual organizations to opt-in to this functionality, which will also trigger data migrations for existing orgs; LD did not really facilitate this. Additional details in Slack.

  • Added this to the OrganizationAbilities object as well, as we'll need frequent access to it in controller endpoints

  • .gitignore was meant to ignore *.db files so that it didn't pick up sqlite database files, however this wasn't working - fixed it while I'm here

Database migrations were based off:

Nothing is wired up yet - this just adds the column.

Client changes in bitwarden/clients#7442.

Code changes

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@eliykat eliykat force-pushed the ac/ac-2025/server-add-organization.flexiblecollections-to-database-and-sprocs branch from 8529f56 to dfae25e Compare January 4, 2024 04:06
r-tome
r-tome previously approved these changes Jan 9, 2024
vincentsalucci
vincentsalucci previously approved these changes Jan 10, 2024
@eliykat eliykat dismissed stale reviews from vincentsalucci and r-tome via 3ade04f January 11, 2024 00:25
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@c553ec6). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3642   +/-   ##
=======================================
  Coverage        ?   32.03%           
=======================================
  Files           ?     1198           
  Lines           ?    63006           
  Branches        ?     4802           
=======================================
  Hits            ?    20186           
  Misses          ?    41779           
  Partials        ?     1041           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rkac-bw rkac-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@eliykat eliykat merged commit b829812 into main Jan 11, 2024
47 checks passed
@eliykat eliykat deleted the ac/ac-2025/server-add-organization.flexiblecollections-to-database-and-sprocs branch January 11, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants