-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-2025] Add Organization.FlexibleCollections to database and sprocs #3642
Merged
eliykat
merged 8 commits into
main
from
ac/ac-2025/server-add-organization.flexiblecollections-to-database-and-sprocs
Jan 11, 2024
Merged
[AC-2025] Add Organization.FlexibleCollections to database and sprocs #3642
eliykat
merged 8 commits into
main
from
ac/ac-2025/server-add-organization.flexiblecollections-to-database-and-sprocs
Jan 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliykat
force-pushed
the
ac/ac-2025/server-add-organization.flexiblecollections-to-database-and-sprocs
branch
from
January 4, 2024 04:06
8529f56
to
dfae25e
Compare
…ollections-to-database-and-sprocs
r-tome
previously approved these changes
Jan 9, 2024
vincentsalucci
previously approved these changes
Jan 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3642 +/- ##
=======================================
Coverage ? 32.03%
=======================================
Files ? 1198
Lines ? 63006
Branches ? 4802
=======================================
Hits ? 20186
Misses ? 41779
Partials ? 1041 ☔ View full report in Codecov by Sentry. |
rkac-bw
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
vincentsalucci
approved these changes
Jan 11, 2024
eliykat
deleted the
ac/ac-2025/server-add-organization.flexiblecollections-to-database-and-sprocs
branch
January 11, 2024 03:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Add a new property/column,
Organization.FlexibleCollections
. This will replace theFlexibleCollections
(MVP) LaunchDarkly feature flag for toggling app behaviour. It defaults tofalse
. The intention is to allow individual organizations to opt-in to this functionality, which will also trigger data migrations for existing orgs; LD did not really facilitate this. Additional details in Slack.Added this to the
OrganizationAbilities
object as well, as we'll need frequent access to it in controller endpoints.gitignore
was meant to ignore*.db
files so that it didn't pick up sqlite database files, however this wasn't working - fixed it while I'm hereDatabase migrations were based off:
Nothing is wired up yet - this just adds the column.
Client changes in bitwarden/clients#7442.
Code changes
Before you submit
dotnet format --verify-no-changes
) (required)