Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-17377: Update text, formatting, and style for the environment selector #4623

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Jan 24, 2025

🎟️ Tracking

PM-17377

📔 Objective

This PR makes small tweaks to the Environment selector UI.

📸 Screenshots

Before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details6f39d5e5-d432-4fc7-960c-4677d679a69f

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (3a6db38) to head (dcae026).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4623   +/-   ##
=======================================
  Coverage   88.39%   88.40%           
=======================================
  Files         603      603           
  Lines       40905    40907    +2     
  Branches     5755     5755           
=======================================
+ Hits        36160    36162    +2     
  Misses       2742     2742           
  Partials     2003     2003           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dseverns-livefront dseverns-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck & @dseverns-livefront

@david-livefront david-livefront added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit 09b898d Jan 24, 2025
9 checks passed
@david-livefront david-livefront deleted the PM-17377-environment-selector branch January 24, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants