-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-15087] Update the device push token every 7 days #4386
Open
mzieniukbw
wants to merge
5
commits into
main
Choose a base branch
from
km/pm-15087
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+87
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the device to receive relevant push notifications, the device needs to be registered with correct Azure Notification Hub tags. If they change, we need to perform migration for all devices. With this change, manual migrations are no longer necessary.
mzieniukbw
changed the title
PM-15087: Update the device push token every 7 days
[PM-15087] Update the device push token every 7 days
Nov 26, 2024
New Issues
Fixed Issues
|
The PushService method result was not mocked and tests had wrong assertions.
mzieniukbw
requested review from
brian-livefront and
david-livefront
as code owners
November 27, 2024 12:12
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4386 +/- ##
==========================================
- Coverage 89.01% 89.01% -0.01%
==========================================
Files 451 451
Lines 39123 39122 -1
Branches 5532 5532
==========================================
- Hits 34827 34826 -1
Misses 2368 2368
Partials 1928 1928 ☔ View full report in Codecov by Sentry. |
mzieniukbw
requested review from
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
November 27, 2024 12:12
SaintPatrck
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15087
📔 Objective
Update the device push token every 7 days.
For the device to receive relevant push notifications, the device needs to be registered with correct Azure Notification Hub tags. If they change, we need to perform migration for all devices. With this change, manual migrations are no longer necessary, since devices updates the token against the Bitwarden server periodically, updating the tags with Azure Notification Hub.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes