Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11598] GitHub Release - Improve tag name and refactor inputs casing #4349

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

vvolkgang
Copy link
Member

@vvolkgang vvolkgang commented Nov 21, 2024

🎟️ Tracking

PM-11598

📔 Objective

  1. Prefix tagnames with "v", following our usual pattern
  2. Refactor inputs casing to kebab-case (thanks @vgrassia! )

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang added the ci/cd Updates to automated workflows label Nov 21, 2024
@vvolkgang vvolkgang requested a review from a team as a code owner November 21, 2024 12:12
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.00%. Comparing base (96bd25e) to head (2b67280).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4349   +/-   ##
=======================================
  Coverage   89.00%   89.00%           
=======================================
  Files         452      452           
  Lines       39155    39155           
  Branches     5524     5524           
=======================================
  Hits        34848    34848           
  Misses       2379     2379           
  Partials     1928     1928           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

github-actions bot commented Nov 21, 2024

Logo
Checkmarx One – Scan Summary & Details7ceaa974-060d-44aa-ae74-f6b6fc13beae

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt: 875 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 26

@vvolkgang vvolkgang enabled auto-merge November 21, 2024 12:19
@vvolkgang vvolkgang added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit d4033a7 Nov 21, 2024
10 checks passed
@vvolkgang vvolkgang deleted the fix-gh-release branch November 21, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Updates to automated workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants