Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-14036: Add extra slider padding #4220

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Nov 1, 2024

🎟️ Tracking

PM-14036

📔 Objective

This PR adds addition end padding to the slider on the Generator Screen. This is an attempt to lower the odds that grabbing the slider thumb when it is at the end of the screen will trigger a navigate-back gesture.

Design approved of this extra padding.

📸 Screenshots

Before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@david-livefront david-livefront changed the title PM-14036: Add extr slider padding PM-14036: Add extra slider padding Nov 1, 2024
Copy link
Collaborator

@dseverns-livefront dseverns-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-livefront
Copy link
Collaborator Author

Thanks @dseverns-livefront

@david-livefront david-livefront added this pull request to the merge queue Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.05%. Comparing base (2eb41e9) to head (d0cb124).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4220   +/-   ##
=======================================
  Coverage   89.05%   89.05%           
=======================================
  Files         445      445           
  Lines       38653    38653           
  Branches     5402     5402           
=======================================
  Hits        34422    34422           
  Misses       2357     2357           
  Partials     1874     1874           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit c2537f3 Nov 1, 2024
9 checks passed
@david-livefront david-livefront deleted the PM-14036-slider-padding branch November 1, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants