Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update androidx dependecies and target API #4212

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Oct 31, 2024

🎟️ Tracking

N/A

📔 Objective

This PR update the Androidx dependencies used by the app as well as updating our target and compile api to 35.

Release notes:

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@david-livefront david-livefront force-pushed the update-androidx-deps branch 2 times, most recently from 8f76148 to 0fd0cd0 Compare October 31, 2024 17:34
@david-livefront david-livefront changed the title Update androidx dependecies Update androidx dependecies and target API Oct 31, 2024
Copy link
Collaborator

@dseverns-livefront dseverns-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.05%. Comparing base (51e2999) to head (f47e556).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4212   +/-   ##
=======================================
  Coverage   89.05%   89.05%           
=======================================
  Files         445      445           
  Lines       38652    38652           
  Branches     5402     5402           
=======================================
  Hits        34421    34421           
  Misses       2357     2357           
  Partials     1874     1874           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold do not merge yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants