Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix after_cleanup plugin call #698

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

decius7bc
Copy link

@decius7bc decius7bc commented Jul 12, 2019

Summary of changes

The function after_cleanup/2 called run/3 obviously by mistake with :after_package instead of :after_cleanup. Plugin callbacks after_cleanup/2 were never run.

This minimal modification ensures expected behavior.

Checklist

  • New functions have typespecs, changed functions were updated
  • Same for documentation, including moduledocs
  • Tests were added or updated to cover changes
  • Commits were squashed into a single coherent commit

Licensing/Copyright

I certify that I own, and have sufficient rights to contribute, all source code and
related material intended to be compiled or integrated with the source code for Distillery
(the "Contribution"). My Contribution is licensed under the MIT License.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant